Skip to content

Add [side] parameter for FormBuilderFilterChip and FormBuilderChoiceChip #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fatyga
Copy link
Contributor

@fatyga fatyga commented Nov 30, 2024

Copy [side] parameter from Material's ChoiceChip widget with documentation. Copy [side] parameter form Material's FilterChip widget.

Connection with issue(s)

Connected to #1328

Solution description

I copied parameter definition from FilterChip and ChoiceChip widgets. I also copied documentation only for FormBuilderChoiceChip, because FormBuilderFilterChip doesn't have documentation.

Screenshots or Videos

Screenshot_20241130_165532

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

Copy [side] parameter from Material's ChoiceChip widget with documentation.
Copy [side] parameter form Material's FilterChip widget.
@fatyga
Copy link
Contributor Author

fatyga commented Dec 5, 2024

Hi, how long do I have to wait for approval?

@deandreamatias
Copy link
Collaborator

@fatyga what is the changes? Only see the updated example dependencies

@fatyga fatyga marked this pull request as draft December 7, 2024 15:46
@fatyga fatyga marked this pull request as ready for review December 7, 2024 15:47
@fatyga
Copy link
Contributor Author

fatyga commented Dec 7, 2024

Sorry, I have forgotten to stage all files. I've fixed that.

@deandreamatias deandreamatias merged commit 11a0eef into flutter-form-builder-ecosystem:main Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants