Skip to content

feat: #1458 improve autovalidate modes #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

deandreamatias
Copy link
Collaborator

@deandreamatias deandreamatias commented Jan 6, 2025

Connection with issue(s)

Close #1457
Close #1364

Connected to #1458

Solution description

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (81b5f5e) to head (1dbe413).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1460      +/-   ##
==========================================
- Coverage   90.09%   90.08%   -0.02%     
==========================================
  Files          21       21              
  Lines         828      827       -1     
==========================================
- Hits          746      745       -1     
  Misses         82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deandreamatias deandreamatias changed the title test: add autovalidate mode test cases on form builder feat: #1458 improve autovalidate modes Jan 6, 2025
@deandreamatias deandreamatias marked this pull request as ready for review January 12, 2025 15:48
@deandreamatias deandreamatias merged commit 042225a into main Jan 13, 2025
6 checks passed
@deandreamatias deandreamatias deleted the feature/1458-improve-autovalidate-modes branch January 13, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[General]: AutovalidateMode.always shouldn't focus to first field Resetting form shows error messages
1 participant