This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Dispose a temporary image that may be created by instantiateImageCodecWithSize #54096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyebrowsoffire
suggested changes
Jul 26, 2024
| ); | ||
| if (!identical(frameInfo.image, scaledImage)) { |
There was a problem hiding this comment.
This doesn't seem right to me, as we actually dispose the original image inside the image scaling code: https://github.com/flutter/engine/pull/54096/files#diff-31d1d1318cb022b618cf4b314284d2555b4219200e8e40f67c9c1bc275ac1986L469
Are we sure this is the actual issue here? Maybe I'm just missing something but it seems like we'd be double-disposing the original image. Perhaps this is just covering up some other problem we have?
There was a problem hiding this comment.
The unit test failures seem to indicate that we are double disposing now with your change, so I suspect this needs to be looked at a bit deeper.
There was a problem hiding this comment.
Looked at this again, and I think the issue is actually that CkResizingCodec._scaleImageUsingDomCanvas was not matching the dispose behavior of ResizingCodec.scaleImageIfNeeded
This is passing CI now - PTAL
jason-simmons
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/54096, Failed to merge flutter/engine/54096 with Pull request flutter/engine/54096 could not be merged: Pull Request is not mergeable. |
jason-simmons
force-pushed
the
bug_147066
branch
from
c18bbc9 to
c7640d4
Compare
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2024
…antiateImageCodecWithSize (flutter/engine#54096)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
…antiateImageCodecWithSize (flutter/engine#54096)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2024
…ions) (#152654) Manual roll requested by [email protected] flutter/engine@32f7888...ed95b49 2024-07-31 [email protected] [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096) 2024-07-31 [email protected] Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266) 2024-07-31 [email protected] Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
…antiateImageCodecWithSize (flutter/engine#54096)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2024
…152658) flutter/engine@32f7888...0fbff21 2024-07-31 [email protected] Remove pre-existing diagnostics with no behavioral changes. (flutter/engine#54264) 2024-07-31 [email protected] Cleanup dart analyze diagnostics in ignored directories. (flutter/engine#54262) 2024-07-31 [email protected] [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096) 2024-07-31 [email protected] Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266) 2024-07-31 [email protected] Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…ions) (flutter#152654) Manual roll requested by [email protected] flutter/engine@32f7888...ed95b49 2024-07-31 [email protected] [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096) 2024-07-31 [email protected] Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266) 2024-07-31 [email protected] Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152658) flutter/engine@32f7888...0fbff21 2024-07-31 [email protected] Remove pre-existing diagnostics with no behavioral changes. (flutter/engine#54264) 2024-07-31 [email protected] Cleanup dart analyze diagnostics in ignored directories. (flutter/engine#54262) 2024-07-31 [email protected] [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096) 2024-07-31 [email protected] Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266) 2024-07-31 [email protected] Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…ions) (flutter#152654) Manual roll requested by [email protected] flutter/engine@32f7888...ed95b49 2024-07-31 [email protected] [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096) 2024-07-31 [email protected] Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266) 2024-07-31 [email protected] Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152658) flutter/engine@32f7888...0fbff21 2024-07-31 [email protected] Remove pre-existing diagnostics with no behavioral changes. (flutter/engine#54264) 2024-07-31 [email protected] Cleanup dart analyze diagnostics in ignored directories. (flutter/engine#54262) 2024-07-31 [email protected] [web] Dispose a temporary image that may be created by instantiateImageCodecWithSize (flutter/engine#54096) 2024-07-31 [email protected] Roll Skia from b5ad5bf3696d to 8db309541ad9 (2 revisions) (flutter/engine#54266) 2024-07-31 [email protected] Roll Dart SDK from 5df6a6e0c037 to efabc9163078 (1 revision) (flutter/engine#54263) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#147066