Skip to content

Match IntelliJ's zoom setting in the embedded DevTools panels #7933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

elliette
Copy link
Member

@elliette elliette commented Feb 5, 2025

Work towards flutter/devtools#8243

Screenshot 2025-02-05 at 3 13 22 PM

After a user updates the zoom in their settings, the next time the DevTools panels are loaded, the new zoom setting will be applied. They can also trigger an immediate refresh of the embedded panel to get the new zoom setting.

@elliette elliette marked this pull request as ready for review February 6, 2025 16:56
@elliette elliette requested a review from jwren February 6, 2025 16:56
Copy link
Member

@jwren jwren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @elliette!

@@ -33,6 +33,11 @@ public void close() {

}

@Override
public void matchIdeZoom() {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally empty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted offline, this is an experimental browser, does not need implementation here.

@elliette elliette merged commit 935c89a into flutter:master Feb 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants