Skip to content

Release the SurfaceTextureSurfaceProducer's surface in the release method #165835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

Release the SurfaceTextureSurfaceProducer's surface in the release method #165835

merged 1 commit into from
Mar 25, 2025

Conversation

jason-simmons
Copy link
Member

The TextureRegistry.SurfaceProducer interface specifies that callers of getSurface should not cache the returned surface. Therefore, it should be safe for SurfaceTextureSurfaceProducer to release this surface when releasing the texture.

Fixes #163235

@jason-simmons
Release the SurfaceTextureSurfaceProducer's surface in the release me…
07a3001 
…thod

The TextureRegistry.SurfaceProducer interface specifies that callers of getSurface should not cache the returned surface.  Therefore, it should be safe for SurfaceTextureSurfaceProducer to release this surface when releasing the texture.

Fixes flutter#163235
@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine repository. See also e: labels. labels Mar 24, 2025
matanlurey
matanlurey approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jason!

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 25, 2025
Merged via the queue into flutter:master with commit b4a69f0 Mar 25, 2025
170 of 171 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
37628e9 
…lease method (flutter/flutter#165835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
ecee647 
…lease method (flutter/flutter#165835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
36050ad 
…lease method (flutter/flutter#165835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
228d5d0 
…lease method (flutter/flutter#165835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
aee54fd 
…lease method (flutter/flutter#165835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
526a90f 
…lease method (flutter/flutter#165835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
90a40af 
…lease method (flutter/flutter#165835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
4cb7890 
…lease method (flutter/flutter#165835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
4eed50c 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
fb75733 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
76e7e43 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
092a0e9 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
2c8241a 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
645477c 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
ee6649d 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
91d700f 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
55cb8df 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
325d919 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
56bcbf6 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
b13bb9c 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
66d0b2b 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
3d3b902 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
b247026 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
b50f424 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
73074c6 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
8352b6c 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
bebd2f3 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
9ea0da7 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
8c017bf 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
c7c5db9 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
d1fccf6 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
acf6a42 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
25eb82c 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
bdb3032 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
67ea134 
…lease method (flutter/flutter#165835)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
b4a69f0 Release the SurfaceTextureSurfaceProducer's surface in the re…
30473de 
…lease method (flutter/flutter#165835)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@jason-simmons
Release the SurfaceTextureSurfaceProducer's surface in the release me…
2b23816 
…thod (flutter#165835)

The TextureRegistry.SurfaceProducer interface specifies that callers of
getSurface should not cache the returned surface. Therefore, it should
be safe for SurfaceTextureSurfaceProducer to release this surface when
releasing the texture.

Fixes flutter#163235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. platform-android Android applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PlatformViewsControllerTest sometimes throws a (non-fatal) resource error
2 participants
@jason-simmons @matanlurey