Skip to content

[camera_avfoundation] Tests backfilling - part 3 #8853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RobertOdrowaz
Copy link
Contributor

Backfills tests for the FLTCam class as part of flutter/flutter#119109

Adds tests for the setFlashMode method of the FLTCam class.

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I linked to at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under.
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@RobertOdrowaz RobertOdrowaz force-pushed the feature/camera-tests-backfilling-part3 branch from 37bb9bb to 09ace2d Compare March 12, 2025 13:43
@RobertOdrowaz
Copy link
Contributor Author

This PR is exempt from both version and changelog updates since it's a pure tests update

PRs that only affect tests.

unless they only affect development of the package, such as test-only changes

@stuartmorgan-g
Copy link
Contributor

@RobertOdrowaz Feel free to ignore the part of the checklist about commenting unless the bot comments (missing tests) or repo_checks fails (version/changelog). I reworded it because a high percentage of first-time contributors were interpreting "is exempt" to just mean "I don't personally feel like it should be necessary" (without actually reading our process). Contributors who know our process can ignore the instructions to comment.

@RobertOdrowaz
Copy link
Contributor Author

Thanks @hellohuanlin

@RobertOdrowaz RobertOdrowaz added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2025
@auto-submit auto-submit bot merged commit ff7724c into flutter:main Mar 14, 2025
82 checks passed
@RobertOdrowaz RobertOdrowaz deleted the feature/camera-tests-backfilling-part3 branch March 14, 2025 09:29
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 14, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 14, 2025
flutter/packages@9cc6f37...ff7724c

2025-03-14 [email protected] [camera_avfoundation] Tests
backfilling - part 3 (flutter/packages#8853)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
Backfills tests for the `FLTCam` class as part of flutter/flutter#119109

Adds tests for the `setFlashMode` method of the `FLTCam` class.

## Pre-Review Checklist
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
Backfills tests for the `FLTCam` class as part of flutter/flutter#119109

Adds tests for the `setFlashMode` method of the `FLTCam` class.

## Pre-Review Checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-ios platform-macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants