Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Ignore SSL certificate errors #2285

Closed
wants to merge 1 commit into from

Conversation

gorphone
Copy link

@gorphone gorphone commented Nov 18, 2019

Description

Ignore SSL certificate errors to resolve the page blank in https protocol

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ened
Copy link
Contributor

ened commented Dec 3, 2019

Hi @gorphone, thank you for the PR.
By default, Flutter plugins should expect or enforce a secure environment, therefore we can not process this PR as-is. However, I can see a use case, especially during local development when it's just may not be feasible to have a properly signed https connection.
In that case, the behavior for SSL certificate checking should be a configurable property.
Would you be willing to work on that?
This would also include a suite of tests to go along with it.
Thank you!

@renenucci
Copy link

renenucci commented May 22, 2020

Another thing, I think that is missing some imports...

import android.webkit.SslErrorHandler; import android.net.http.SslError;

on file FlutterWebViewClient.java

@cyanglaz
Copy link
Contributor

@gorphone As mentioned by @ened

By default, Flutter plugins should expect or enforce a secure environment, therefore we can not process this PR as-is. However, I can see a use case, especially during local development when it's just may not be feasible to have a properly signed https connection.

I'm going to close this PR. If you want to work on a PR that adding a configurable SSL checking property, please feel free to open another PR or reopen this PR if it is ready :)

@mdmota
Copy link

mdmota commented Apr 7, 2022

How is this customization with the latest version of the plugin?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants