-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Updates component theme normalization breaking changes #12057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates component theme normalization breaking changes #12057
Conversation
Visit the preview URL for this PR (updated for commit dd6a618): https://flutter-docs-prod--pr12057-migration-guide-for-bottom-hdj5mq0n.web.app |
c81091b
to
7cd1fb9
Compare
7cd1fb9
to
3e92ead
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
src/content/release/breaking-changes/component-theme-normalization-updates.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/component-theme-normalization-updates.md
Show resolved
Hide resolved
…arTheme, BottomAppBarTheme and InputDecorationTheme Add BottomAppBarTheme normalization to align with Flutter Material's component theme conventions
…component theme conventions
…o create ThemeData or use ThemeData.copyWith
16c1d9b
to
dd6a618
Compare
@huycozy, can we land this? I saw that @QuncCccccc left a comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@QuncCccccc thanks for reviewing this. |
Add
BottomAppBarTheme
normalization update to align with Flutter Material's component theme conventions.Presubmit checklist