Adding gitea provider #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Malar Kannan <[email protected]>
2. underscored unused args 3. commented exported api 4. enabled custom domain auth_test cases 5. typo, unuse var fixes 6. pagination support and bugfixes Signed-off-by: Malar Kannan <[email protected]>
Signed-off-by: Soule BA <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
==========================================
+ Coverage 59.48% 59.69% +0.20%
==========================================
Files 44 94 +50
Lines 3019 7473 +4454
==========================================
+ Hits 1796 4461 +2665
- Misses 1038 2383 +1345
- Partials 185 629 +444
☔ View full report in Codecov by Sentry. |
Signed-off-by: Soule BA <[email protected]>
|
@malarinv this is based on your work. We should have a single PR. Either give me access to your branch so I can push those changes, or close your existing pr. |
Signed-off-by: Soule BA <[email protected]>
makkes
reviewed
Jun 5, 2023
makkes
reviewed
Jun 5, 2023
Signed-off-by: Soule BA <[email protected]>
Signed-off-by: Soule BA <[email protected]>
makkes
reviewed
Jun 6, 2023
Signed-off-by: Soule BA <[email protected]>
makkes
reviewed
Jun 6, 2023
Signed-off-by: Soule BA <[email protected]>
makkes
reviewed
Jun 6, 2023
| @@ -33,7 +33,7 @@ type BranchClient struct { | |||
| } | |||
|
|
|||
| // Create creates a branch with the given specifications. | |||
| // Creating a branch from a commit is noy supported by Gitea. | |||
| // Creating a branch from a commit is noy supported by Gitea, the sha refers to the branch to create from. | |||
There was a problem hiding this comment.
Suggested change
| // Creating a branch from a commit is noy supported by Gitea, the sha refers to the branch to create from. | |
| // Creating a branch from a commit is not supported by Gitea, the `sha` refers to the branch to create from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #147
This PR completes #148 by correcting and adding missing features and tests cases.
Note: Some features are not yet available