Skip to content

fix(vndr user repos) add support for user specified package locations (#316) #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2018

Conversation

zlav
Copy link
Member

@zlav zlav commented Oct 5, 2018

No description provided.

@zlav zlav requested a review from elldritch October 5, 2018 00:08
Copy link
Contributor

@elldritch elldritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a fixture for the weird vndr lockfile.

@coveralls
Copy link

coveralls commented Oct 5, 2018

Coverage Status

Coverage decreased (-0.08%) to 35.549% when pulling b143962 on fix/vndr-user-repos into ca28520 on master.

@zlav zlav force-pushed the fix/vndr-user-repos branch from 13acb2e to ed9f00a Compare October 5, 2018 02:51
Copy link
Contributor

@elldritch elldritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit. Ready to merge.

"github.com/fossas/fossa-cli/buildtools"
"github.com/fossas/fossa-cli/buildtools/vndr"
"github.com/fossas/fossa-cli/pkg"
"github.com/stretchr/testify/assert"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Import grouping.

I think GolangCI might catch this for us when configured, but not by default. Might be worth looking into that, but that configuration should be a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a known issue in goimports at the moment that is on their roadmap. I always thought I was safe running goimport gofmt golint in my shell before pushing. Link to an example that fixes this problem at least before commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants