-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: Standardize width of footer #5514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Standardize width of footer #5514
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7ulrjnhw2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a new line
</div> | ||
</div> | ||
</div> | ||
<div class="three wide column"></div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz add a newline at the end of the file.
Codecov Report
@@ Coverage Diff @@
## development #5514 +/- ##
===============================================
- Coverage 23.25% 23.07% -0.18%
===============================================
Files 493 493
Lines 5182 5209 +27
Branches 38 38
===============================================
- Hits 1205 1202 -3
- Misses 3972 4002 +30
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a need of such drastic structural changes? Please make minimum changes necessary
@iamareebjamal sir, please have a look at changes done by me. i have already done minimum changes needed. I have removed the outer container and replace it with a Semantic UI Grid. |
@iamareebjamal sir, have a look at this. There is no such drastic change in structure. Only outer centered aligner container is replaced with semantic ui grid and for matching left side bar and right twitter widget, 2 empty columns are added. |
Fixes #5511
Short description of what this resolves:
On the public event pages the sidebar spacing is different to the footer left and right spacing. This PR matched the left and right spacing of footer with sidebar and social links widget of public event page.
The footer is having a grid of 4 column which is wrapped in a center aligned container.
I have removed the container and created a grid with 3 columns. the 2 side column are empty(to match space with side bar of public event page and right side twitter widget). the center column is a nested grid which contain all footer data(grid of footer and all four columns.).
now footer is matched with the public event page.
Changes proposed in this pull request:
Checklist
development
branch.screenshots
before

after
