Skip to content

fix: Standardize width of footer #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Nov 6, 2020

Fixes #5511

Short description of what this resolves:

On the public event pages the sidebar spacing is different to the footer left and right spacing. This PR matched the left and right spacing of footer with sidebar and social links widget of public event page.

The footer is having a grid of 4 column which is wrapped in a center aligned container.
I have removed the container and created a grid with 3 columns. the 2 side column are empty(to match space with side bar of public event page and right side twitter widget). the center column is a nested grid which contain all footer data(grid of footer and all four columns.).
now footer is matched with the public event page.

Changes proposed in this pull request:

  • matched the left and right spacing of footer with public event page side bar.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

screenshots

before
1111111111111111111111

after
5511

@vercel
Copy link

vercel bot commented Nov 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/7ulrjnhw2
✅ Preview: https://open-event-frontend-git-fix-5511.eventyay.vercel.app

Copy link
Member

@Raunaksingh100 Raunaksingh100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a new line

</div>
</div>
</div>
<div class="three wide column"></div>
</div>
Copy link
Member

@Raunaksingh100 Raunaksingh100 Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz add a newline at the end of the file.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #5514 (e677af0) into development (190a3d6) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5514      +/-   ##
===============================================
- Coverage        23.25%   23.07%   -0.18%     
===============================================
  Files              493      493              
  Lines             5182     5209      +27     
  Branches            38       38              
===============================================
- Hits              1205     1202       -3     
- Misses            3972     4002      +30     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/events/view.js 0.00% <0.00%> (ø)
app/controllers/events/view/index.js 0.00% <0.00%> (ø)
app/controllers/events/view/scheduler.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/create.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/edit.js 0.00% <0.00%> (ø)
app/controllers/events/view/settings.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers/create.js 0.00% <0.00%> (ø)
app/controllers/events/view/speakers/edit.js 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e0cbd...552dd17. Read the comment docs.

mariobehling
mariobehling previously approved these changes Nov 6, 2020
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a need of such drastic structural changes? Please make minimum changes necessary

@sachinchauhan2889
Copy link
Contributor Author

sachinchauhan2889 commented Nov 7, 2020

@iamareebjamal sir, please have a look at changes done by me. i have already done minimum changes needed. I have removed the outer container and replace it with a Semantic UI Grid.
In github it is showing i have changed 117 lines but actually i have changed 2 line and add 3 lines. i have screenshot of VS Code diaplaying changes done by me. please have a look at this.

5511 chat

@sachinchauhan2889
Copy link
Contributor Author

sachinchauhan2889 commented Nov 7, 2020

@iamareebjamal sir, have a look at this. There is no such drastic change in structure. Only outer centered aligner container is replaced with semantic ui grid and for matching left side bar and right twitter widget, 2 empty columns are added.
I think it is good approach for this problem.
Sir if you told to change, i will think for another solution.
I think it looks drastic because it is showing 117 added and 114 lines deleted. But i manipulated only 4-5 lines. Just look this please. Sir

@iamareebjamal iamareebjamal changed the title Standardize width of footer fix: Standardize width of footer Nov 7, 2020
@auto-label auto-label bot added the fix label Nov 7, 2020
@iamareebjamal iamareebjamal merged commit a168b02 into fossasia:development Nov 7, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the fix-5511 branch November 8, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Event Pages: Standardize width of sidebar and make it same as the footer
4 participants