-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: Public schedule mobile view made responsive #5896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Public schedule mobile view made responsive #5896
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2vy5ccdu8 |
Looks like you did not pull in all the changes that happened on this area before. Please resolve conflicts. |
Yes just realized, updating it. Thanks |
8a05acd
to
adfa37d
Compare
Codecov Report
@@ Coverage Diff @@
## development #5896 +/- ##
============================================
Coverage 23.36% 23.36%
============================================
Files 512 512
Lines 5525 5525
Branches 68 68
============================================
Hits 1291 1291
Misses 4217 4217
Partials 17 17 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which breakpoint? |
u can do it for mobile view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine for me. Pls add screenshots before/after for #5908
Already added for both mobile & desktop. Check screenshots marked as "without social links". |
Great. Working fine for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks already much better, but the test page is different to your screenshots for me. I think the following makes sense for the moment (but we need to iterate a bit more after this PR and see what works and what does not). Please implement the following order for now:
- Date and Time
- Social and Web Links
- Session and date filter, Search, Sort by
- Tracks and Rooms filter
- The list of sessions
@mariobehling Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good for me. Let's test this more and iterate further from here. Cheers.
Fixes #5893 #5908
Short description of what this resolves:
Screenshots -
DEKSTOP VIEW :
without social links -

with social links -

MOBILE VIEW :
without social links -

with social links -

Checklist
development
branch.