Skip to content

fix: Public schedule mobile view made responsive #5896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 17, 2020

Conversation

MeghalBisht
Copy link
Member

@MeghalBisht MeghalBisht commented Dec 3, 2020

Fixes #5893 #5908

Short description of what this resolves:

  1. Moved date and filters to the top and displayed tracks and rooms next to each other.
  2. Removed extra space b/w date and track blocks when social links are not present

Screenshots -

DEKSTOP VIEW :

without social links -
2020-12-05 (6)

with social links -
2020-12-05 (8)

MOBILE VIEW :

without social links -
2020-12-05 (5)

with social links -
2020-12-05 (9)

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Dec 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2vy5ccdu8
✅ Preview: https://open-event-frontend-git-responsive-5893.eventyay.now.sh

@mariobehling
Copy link
Member

Looks like you did not pull in all the changes that happened on this area before. Please resolve conflicts.

@MeghalBisht
Copy link
Member Author

Looks like you did not pull in all the changes that happened on this area before. Please resolve conflicts.

Looks like you did not pull in all the changes that happened on this area before. Please resolve conflicts.

Yes just realized, updating it. Thanks

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #5896 (13f0992) into development (44fccad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5896   +/-   ##
============================================
  Coverage        23.36%   23.36%           
============================================
  Files              512      512           
  Lines             5525     5525           
  Branches            68       68           
============================================
  Hits              1291     1291           
  Misses            4217     4217           
  Partials            17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44fccad...13f0992. Read the comment docs.

Copy link
Member

@divyamtayal divyamtayal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls decrease the size of tracks and rooms links to .9rem

Before After
Screen Shot 2020-12-04 at 10 42 19 Screen Shot 2020-12-04 at 10 43 13

@MeghalBisht
Copy link
Member Author

MeghalBisht commented Dec 4, 2020

Pls decrease the size of tracks and rooms links to .9rem

Which breakpoint?

@divyamtayal
Copy link
Member

Pls decrease the size of tracks and rooms links to .9rem

Which breakpoint?

u can do it for mobile view

Copy link
Member

@divyamtayal divyamtayal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine for me. Pls add screenshots before/after for #5908

@MeghalBisht
Copy link
Member Author

Working fine for me. Pls add screenshots before/after for #5908

Already added for both mobile & desktop. Check screenshots marked as "without social links".

@divyamtayal
Copy link
Member

divyamtayal commented Dec 7, 2020

Already added for both mobile & desktop. Check screenshots marked as "without social links".

Great. Working fine for me

divyamtayal
divyamtayal previously approved these changes Dec 7, 2020
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks already much better, but the test page is different to your screenshots for me. I think the following makes sense for the moment (but we need to iterate a bit more after this PR and see what works and what does not). Please implement the following order for now:

  1. Date and Time
  2. Social and Web Links
  3. Twitter
  4. Session and date filter, Search, Sort by
  5. Tracks and Rooms filter
  6. The list of sessions

@MeghalBisht
Copy link
Member Author

Changed order screenshots-
4 and 5 order is reversed as 5 and 6 together is added as {{outlet}}.
2020-12-08 (2)
2020-12-08 (3)

@MeghalBisht
Copy link
Member Author

@mariobehling Please review.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good for me. Let's test this more and iterate further from here. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Schedule Mobile View: Move date and filters up
4 participants