Skip to content

wip: fmt solar #10907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 24 commits into
base: dani/fmt-solar
Choose a base branch
from
Draft

wip: fmt solar #10907

wants to merge 24 commits into from
+16,191 −10,945

Conversation

0xrusowsky
Copy link
Contributor

@0xrusowsky 0xrusowsky commented Jul 2, 2025 •
edited
Loading

tests state

  • ArrayExpressions:
    • TODO: print cmnt before memory kw once span is available (solar).
    • STYLE: Is the rest acceptable?
  • BlockComments
  • BlockCommentsFunction
  • ConditionalOperatorExpression
  • ConstructorDefinition
  • ConstructorModifierStyle
  • ContractDefinition
    • STYLE: Is it acceptable?
  • DocComments
    • TODO: wrap comments
  • DoWhileStatement
    • STYLE: OK?
    • TODO: try to improve nested conditional expressions
  • EmitStatement
  • EnumDefinition
  • EnumVariants
  • ErrorDefinition
  • EventDefinition
  • ForStatement
    • STYLE: OK?
    • TODO: try to improve nested conditional expressions
  • FunctionCall
    • TODO: enhance PP so that trailing comments aren't accounted for when breaking lines after a semicolon.
  • FunctionCallArgsStatement
    • STYLE: Is it acceptable?
  • FunctionDefinition
    • STYLE: Is it acceptable?
  • FunctionDefinitionWithFunctionReturns
  • FunctionType
    • STYLE: is it acceptable?
  • HexUnderscore
  • IfStatement
    • TODO: figure out correct comment placements + condition parenthesis wrapping + support config line wrapping
  • IfStatement2
  • ImportDirective
  • InlineDisable
    • FIX: invalid output
  • IntTypes
  • LiteralExpression
    • FIX: idempotency (comment-related)
  • MappingType
    • TODO: comments
  • ModifierDefinition
  • NamedFunctionCallExpression
    • FIX: idempotency (comment-related)
  • NumberLiteralUnderscore
  • OperatorExpressions
    • STATUS: OKish
    • TODO: improve nested conditional expressions
  • PragmaDirective
  • Repros
    • TODO: check boxes, panics
  • ReturnStatement
    • FIX: idempotency (comment-related)
  • RevertNamedArgsStatement
    • TODO: comments
  • RevertStatement
    • FIX: idempotency (comment-related)
  • SimpleComments
    • FIX: idempotency (comment-related)
  • SortedImports
    • FIX: sorting order
  • StatementBlock
  • StructDefinition
  • ThisExpression
  • TrailingComma
    • NOTE: solar error
  • TryStatement
    • STYLE: is it acceptable?
  • TypeDefinition
  • UnitExpression
    • FIX: idempotency (comment-related)
  • UsingDirective
  • VariableAssignment
    • FIX: variable assignment
  • VariableDefinition
    • FIX: variable assignment + declaration
  • WhileStatement
    • STATUS: OKish
    • TODO: improve nested conditional expressions
  • Yul
    • FIX: idempotency (comment-related)
  • YulStrings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr will be requested when the pull request is marked ready for review klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy will be requested when the pull request is marked ready for review grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya will be requested when the pull request is marked ready for review yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks will be requested when the pull request is marked ready for review zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xrusowsky