feat: email template in settings #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lms
|
||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
email-template-list
|
| Run status |
|
| Run duration | 00m 32s |
| Commit |
|
| Committer | Jannat Patel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
| View all changes introduced in this branch ↗︎ | |
There was a problem hiding this comment.
Pull Request Overview
Adds the ability to manage Email Templates directly in the frontend settings, including list, create, edit, and delete flows.
- Hooked up “Create” action in BatchForm to open the Email Templates modal
- Extended SettingFields and Settings modal to include a new “Email Templates” tab
- Introduced
EmailTemplates.vueandEmailTemplateModal.vue, plus layout tweaks in PaymentSettings, SettingFields, and BrandSettings
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/pages/BatchForm.vue | Added onCreate handler to link into the Email Templates settings |
| frontend/src/components/SettingFields.vue | Updated width classes and bound description prop on Link |
| frontend/src/components/PaymentSettings.vue | Added transform + arrangeFields to reorder fields |
| frontend/src/components/Modals/Settings.vue | Imported and wired up the new Email Templates tab |
| frontend/src/components/Modals/EmailTemplateModal.vue | New modal component for creating/editing email templates |
| frontend/src/components/EmailTemplates.vue | New list view component to display and delete templates |
| frontend/src/components/Categories.vue | Minor padding and font-size adjustment |
| frontend/src/components/BrandSettings.vue | Fixed div nesting and moved update button into correct wrapper |
Comments suppressed due to low confidence (2)
frontend/src/components/EmailTemplates.vue:1
- This new component covers list display and modal interactions but has no accompanying unit or integration tests; consider adding tests for row clicks, opening the modal, and delete flows.
<template>
frontend/src/components/Modals/EmailTemplateModal.vue:1
- The modal for creating/editing templates includes multiple branches (new vs edit, HTML vs text) but currently lacks tests; add coverage for form validation, save success/error, and toggle logic.
<template>
|
🎉 This PR is included in version 2.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now create and edit Email Templates from the frontend