Skip to content

fix(view): assignment checkbox #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

huyenltnguyen
Copy link
Member

Checklist:

Closes #1503

Tested on Odin - Learn HTML Foundations - Lesson A

Before After
Screenshot 2025-05-16 at 14 18 58 Screenshot 2025-05-22 at 15 30 09

@huyenltnguyen huyenltnguyen requested a review from a team as a code owner May 22, 2025 08:34
@Sembauke
Copy link
Member

We will need to add a Material widget as its parent. If you check the mobile app on your phone you will see what it used to look like.

@Sembauke
Copy link
Member

Also, I had this one open #1501 - might be useful?

@huyenltnguyen
Copy link
Member Author

If you check the mobile app on your phone you will see what it used to look like.

The prod version has an a11y issue, in that the white link text on a gray background produces a low contrast ratio.

My attempt to fix it is simply removing the gray background. If we want to keep it, we'd need to dynamically change the link text color (and I think that would require calling parser.parse() conditionally, with the link text color as an argument).

@Sembauke Sembauke merged commit 25af4ee into freeCodeCamp:main Jun 5, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assignment checkbox having incorrect style
3 participants