Skip to content

fix(FormControl): handle props spreading properly #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huyenltnguyen
Copy link
Member

Checklist:

We're passing the combined class names (default + custom) to the component, but the default class names are overridden by the custom className because we're spreading the entire props object after that.

const classes = [className, defaultClasses, variantClass].join(" ");
return <Component id={id || controlId} className={classes} {...props} />;

@huyenltnguyen huyenltnguyen requested a review from a team as a code owner June 15, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant