Skip to content

Mobile #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 26, 2025
Merged

Mobile #128

merged 16 commits into from
Jun 26, 2025

Conversation

fretchen
Copy link
Owner

No description provided.

@fretchen fretchen requested a review from Copilot June 26, 2025 05:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the legacy TitleBar and inline SupportArea components with styled <h1> headings, refactors core layout styles into a responsive base card system, and splits support logic into a standalone hook and two new UI components.

  • Remove TitleBar component/props and migrate to styled <h1>
  • Refactor layouts/styles.ts to introduce baseContentCard, responsive entry/card styles, and titleBar
  • Convert SupportArea into useSupportAction hook; add StarSupport and MetadataLine components; update tests and page files

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
website/types/components.ts Remove TitleBarProps interface
website/layouts/styles.ts Introduce baseContentCard, baseContentCardList, titleBar and responsive updates
website/hooks/useSupportAction.ts Convert SupportArea logic into useSupportAction hook
website/components/StarSupport.tsx New compact support button component with two variants
website/components/MetadataLine.tsx New metadata line component for date and support button
website/components/EntryList.tsx Wrap entire entry in <Link>, use unified entry styles
website/components/Card.tsx Update to use baseContentCard and link wrapper
website/layouts/LayoutDefault.tsx Add scroll indicator logic and embed <Footer>
website/pages///+Page.tsx Replace <TitleBar> with <h1 className={titleBar.title}>
website/test/EntryList.test.tsx Update tests to use link-wrapped cards and type imports
Comments suppressed due to low confidence (3)

website/components/StarSupport.tsx:1

  • Add unit tests for the new StarSupport component to cover both variants and loading/error states.
import * as React from "react";

website/components/MetadataLine.tsx:1

  • Add tests for MetadataLine to verify date formatting, conditional rendering, and support button behavior.
import * as React from "react";

website/hooks/useSupportAction.ts:11

  • [nitpick] Consider making the url parameter optional (e.g., url?: string) so the hook can be called without unintended side effects when support is disabled.
export function useSupportAction(url: string) {

@fretchen fretchen merged commit ff60148 into main Jun 26, 2025
3 checks passed
@fretchen fretchen deleted the mobile branch June 26, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant