Skip to content

Added VirtualCapacity to MachineClass NodeTemplate #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added VirtualCapacity to MachineClass NodeTemplate #998

wants to merge 1 commit into from

Conversation

elankath
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Machine Class now has VirtualCapacity that maps to WorkerPool's NodeTemplate VirtualCapacity.

@elankath elankath requested a review from a team as a code owner May 27, 2025 09:28
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@elankath elankath self-assigned this May 27, 2025
@elankath elankath changed the title added VirtualCapacity to NodeTemplate Added VirtualCapacity to MachineClass NodeTemplate May 27, 2025
@gardener-robot gardener-robot added the needs/review Needs review label May 27, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 27, 2025
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label May 27, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 27, 2025
aaronfern
aaronfern reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would also need to add the field to types.go here: https://github.com/gardener/machine-controller-manager/blob/master/pkg/apis/machine/types.go#L737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfern aaronfern aaronfern left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@elankath elankath

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@elankath @CLAassistant @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot @lenkite