fix(debug_files): Don't call xcodebuild
#2443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Mar 27, 2025
8 tasks
The code which reads in the `info_plist` (which we never end up using here) internally calls `xcodebuild`. If `xcodebuild` then hangs for whatever reason, then the Sentry CLI will also hang on the upload. Since we don't need to read the `info_plist` anyway, let's just get rid of it. Fixes #2440
szokeasaurusrex
force-pushed
the
szokeasaurusrex/dont-call-xcodebuild-debug-files-upload
branch
from
97482b9 to
f661997
Compare
szokeasaurusrex
deleted the
szokeasaurusrex/dont-call-xcodebuild-debug-files-upload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code which reads in the
info_plist(which we never end up using here) internally callsxcodebuild. Ifxcodebuildthen hangs for whatever reason, then the Sentry CLI will also hang on the upload.Since we don't need to read the
info_plistanyway, let's just get rid of it.Fixes #2440