Skip to content

test(sourcemaps): Assert injection outputs #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Apr 30, 2025

Most of our tests for sourcemaps inject only assert the stdout of the command and its exit status, but do not verify that the injected files match our expectation.

This test introduces a generalized method to verify the outputs of the commands. The expected outputs have been copied from the actual outputs of the tests at the time of authoring this commit; I assume that the current behavior is the correct behavior.

Closes #2482

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/assert-inject-contents branch from b3f2396 to 102820b Compare April 30, 2025 12:33
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review April 30, 2025 12:57
Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's much cleaner.

@szokeasaurusrex szokeasaurusrex merged commit 102820b into master Apr 30, 2025
17 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/assert-inject-contents branch April 30, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test injection output
2 participants