ref: Separate LegacyUploadContext for legacy uploads
#2494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/legacy-upload-context
branch
from
156f7af to
e7dfc50
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors upload handling by extracting a new LegacyUploadContext to distinguish legacy (non‑chunked) uploads from chunked uploads.
- Introduces LegacyUploadContext and its error enumeration to enforce a required release and single project for legacy uploads.
- Updates conversion and display logic to use LegacyUploadContext instead of UploadContext in various modules.
- Adjusts API and command calls to accommodate the new type.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/file_upload.rs | Added LegacyUploadContext and its Display, Error, and TryFrom implementations. |
| src/commands/files/upload.rs | Updated upload function to convert UploadContext to LegacyUploadContext. |
| src/api/mod.rs | Replaced usage of UploadContext with LegacyUploadContext in API calls. |
loewenheim
approved these changes
May 7, 2025
szokeasaurusrex
force-pushed
the
szokeasaurusrex/legacy-upload-context
branch
2 times, most recently
from
2669216 to
813fa81
Compare
Legacy (i.e. non-chunked) are distinct from chunked uploads, so it makes sense to have a separate struct to enforce these differences via the type system. Specifically, legacy uploads must be associated with a release, whereas this is not required for many chunk uploads. Legacy uploads must also be associated with at most one project, whereas chunked uploads can have multiple projects (support for which we will add in the CLI with #2408)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/legacy-upload-context
branch
from
813fa81 to
8a63fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy (i.e. non-chunked) are distinct from chunked uploads, so it makes sense to have a separate struct to enforce these differences via the type system.
Specifically, legacy uploads must be associated with a release, whereas this is not required for many chunk uploads. Legacy uploads must also be associated with at most one project, whereas chunked uploads can have multiple projects (support for which we will add in the CLI with #2408)