-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add documentation for python clickhouse-driver integration #7129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for python clickhouse-driver integration #7129
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks @mimre25 ! I'll let Anton take a first pass at these docs and then I'll review. |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
We still haven't gotten around to review the SDK PR. I've added it and this PR to our internal board so that we pick it up soon. |
@antonpirker is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with these docs! Made some minor suggestions that I'll go ahead and incorporate. After that, you're good from the docs side!
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
This adds the documentation for a new python integration for
clickhouse-driver
.See getsentry/sentry-python#2154.
Companion PR: getsentry/sentry-python#2167
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Extra resources