Skip to content

feat(solidstart)!: No longer export sentrySolidStartVite #15143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/migration/v8-to-v9.md
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,10 @@ Sentry.init({
- The `addNormalizedRequestDataToEvent` method has been removed. Use `httpRequestToRequestData` instead and put the resulting object directly on `event.request`.
- A `sampleRand` field on `PropagationContext` is now required. This is relevant if you used `scope.setPropagationContext(...)`

### `@sentry/solidstart`

- The `sentrySolidStartVite` plugin is no longer exported. Instead, wrap the SolidStart config with `withSentry` and provide Sentry options as the second parameter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to be extra cool, you could add an example code snippet here of how that migration will look. Once we write this migration guide out we are gonna have more of those so we might already get started with that.


#### Other/Internal Changes

The following changes are unlikely to affect users of the SDK. They are listed here only for completion sake, and to alert users that may be relying on internal behavior.
Expand Down
2 changes: 1 addition & 1 deletion packages/solidstart/src/config/withSentry.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { logger } from '@sentry/core';
import type { Nitro } from 'nitropack';
import { addSentryPluginToVite } from '../vite';
import { addSentryPluginToVite } from '../vite/sentrySolidStartVite';
import type { SentrySolidStartPluginOptions } from '../vite/types';
import {
addDynamicImportEntryFileWrapper,
Expand Down
1 change: 0 additions & 1 deletion packages/solidstart/src/index.server.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
export * from './server';
export * from './vite';
export * from './config';
1 change: 0 additions & 1 deletion packages/solidstart/src/index.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// exports in this file - which we do below.
export * from './client';
export * from './server';
export * from './vite';
export * from './config';

import type { Client, Integration, Options, StackParser } from '@sentry/core';
Expand Down
1 change: 0 additions & 1 deletion packages/solidstart/src/vite/index.ts

This file was deleted.

Loading