Skip to content

feat(node): Add includeServerName option #16442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jun 2, 2025

@timfish timfish requested a review from AbhiPrasad June 2, 2025 09:41
Copy link
Contributor

github-actions bot commented Jun 2, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.99 kB - -
@sentry/browser - with treeshaking flags 23.76 kB - -
@sentry/browser (incl. Tracing) 38.29 kB - -
@sentry/browser (incl. Tracing, Replay) 76.43 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.55 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 81.19 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 93.27 kB - -
@sentry/browser (incl. Feedback) 40.73 kB - -
@sentry/browser (incl. sendFeedback) 28.7 kB - -
@sentry/browser (incl. FeedbackAsync) 33.59 kB - -
@sentry/react 25.76 kB - -
@sentry/react (incl. Tracing) 40.29 kB - -
@sentry/vue 28.34 kB - -
@sentry/vue (incl. Tracing) 40.13 kB - -
@sentry/svelte 24.01 kB - -
CDN Bundle 25.48 kB - -
CDN Bundle (incl. Tracing) 38.48 kB - -
CDN Bundle (incl. Tracing, Replay) 74.33 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 79.75 kB - -
CDN Bundle - uncompressed 74.41 kB - -
CDN Bundle (incl. Tracing) - uncompressed 113.89 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 227.86 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.69 kB - -
@sentry/nextjs (client) 41.96 kB - -
@sentry/sveltekit (client) 38.79 kB - -
@sentry/node 149.88 kB +0.01% +9 B 🔺
@sentry/node - without tracing 98.13 kB +0.01% +7 B 🔺
@sentry/aws-serverless 123.89 kB +0.01% +6 B 🔺

View base workflow run

@timfish timfish requested a review from AbhiPrasad June 2, 2025 18:13
@AbhiPrasad
Copy link
Member

One more thing - needs tests!

@AbhiPrasad AbhiPrasad changed the title feat(node): Add skipIncludingServerName option feat(node): Add includeServerName option Jun 2, 2025
@Lms24
Copy link
Member

Lms24 commented Jun 3, 2025

Gonna merge this in to get it out in the next release. Thanks Tim!

@Lms24 Lms24 merged commit aa24b14 into develop Jun 3, 2025
111 checks passed
@Lms24 Lms24 deleted the timfish/feat/skip-including-server-name branch June 3, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to Node SDK to stop setting server_name
3 participants