`start_span` API not as context manager

[sentrivana]

Problem

Before POTel, you could do:

span = start_span(...)
sentry_sdk.get_current_scope().span = span   # forgot this initially, in case you're confused by the comments
# do stuff
span.finish()

i.e., start and finish a span without using a context manager.

With the current POTel design, this would create an inactive span (not attached to the current span as a child span) because the context attach/detach happens in __enter__ and __exit__, respectively.

This might break a lot of setups -> we should find a way to still support this, while also giving people the possibility to create inactive spans.

(Same for start_transaction.)

Solution

• make the code snippet above work in POTel to not break users (i.e., implement the scope.span setter) and deprecate it
• add a span.activate() method that is a user-friendly equivalent of setting the span on the scope

[sl0thentr0py]

in the older way, you would still have to add the span to scope manually, so the behaviour is kinda the same.

sentry-python/sentry_sdk/tracing.py

Lines 360 to 366 in cd15bff

	def __enter__(self):
	# type: () -> Span
	scope = self.scope or sentry_sdk.get_current_scope()
	old_span = scope.span
	scope.span = self
	self._context_manager_state = (scope, old_span)
	return self

[antonpirker]

Some of our integrations call span.__enter__() and span.__exit__() manually, because a context manager would not work: https://github.com/getsentry/sentry-python/blob/antonpirker/potel/sampler/sentry_sdk/integrations/anthropic.py#L100

Maybe we should make this an official api?
Like:

span = start_span(...)
span.activate()
# do stuff
span.finish()

[sentrivana]

If anyone is missing this functionality let's tell them to use __enter__/__exit__ directly or use the underlying OTel API.

[sentrivana]

Maybe check docs if we're promoting start_span without the context manager and update them @sentrivana