Skip to content

Update sanic integration #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Update sanic integration #2821

merged 8 commits into from
Apr 4, 2024

Conversation

hamedsh
Copy link
Contributor

@hamedsh hamedsh commented Mar 14, 2024

in Sanic, for some exceptions, quiet variables are set to True (https://github.com/hamedsh/sanic/blob/b8ec9ed3e6f63f4c61fd45d3e09cfc9457a53b82/sanic/exceptions.py#L9) these kinds of exceptions, do not exist in the stderr, but exist in the sentry panel.

by this modification, these kinds of exceptions will not sent to the sentry hub.

hamedsh and others added 7 commits March 14, 2024 14:01
in Sanic, for some exceptions, quiet variables are set to True
these kinds of exceptions, do not exist in the stderr, but exist in the sentry panel.
by this modification, these kinds of exceptions will not sent to the sentry hub.
@antonpirker antonpirker added the Trigger: tests using secrets PR code is safe; run CI label Apr 4, 2024
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot removed the Trigger: tests using secrets PR code is safe; run CI label Apr 4, 2024
@antonpirker antonpirker enabled auto-merge (squash) April 4, 2024 08:25
@antonpirker antonpirker merged commit 19fb4e5 into getsentry:master Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants