Skip to content

Migrate to modern threading interface #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

emmanuel-ferdman
Copy link
Contributor

PR Summary

This small PR resolves the threading library warnings, which you can find in the CI logs:

/home/runner/work/sentry-python/sentry-python/tests/conftest.py:608: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
    mock_server_thread.setDaemon(True)

@emmanuel-ferdman emmanuel-ferdman requested a review from a team as a code owner June 9, 2025 20:48
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (7f8571c) to head (926b4f1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4452      +/-   ##
==========================================
- Coverage   80.68%   80.63%   -0.05%     
==========================================
  Files         142      142              
  Lines       15986    15986              
  Branches     2732     2732              
==========================================
- Hits        12898    12891       -7     
- Misses       2230     2238       +8     
+ Partials      858      857       -1     

see 5 files with indirect coverage changes

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@sl0thentr0py sl0thentr0py merged commit 4420c4d into getsentry:master Jun 10, 2025
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants