Skip to content
This repository was archived by the owner on Jun 16, 2025. It is now read-only.

Remove unnecessary extra url in requirements file #93

Closed
wants to merge 2 commits into from

Conversation

oliviagyg
Copy link
Contributor

Description

It's included as a parameter (--extra-index-url), so we don't need it in the requirements file.

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed

Added to documentation?

  • 👍 README.md
  • 👍 CHANGELOG.md
  • 👍 Additional documentation in /docs
  • 👍 Relevant code documentation
  • 🙅 no, because they aren’t needed

@oliviagyg oliviagyg requested a review from a team as a code owner November 21, 2024 10:51
@oliviagyg
Copy link
Contributor Author

This doesn't work, actually...we scan the requirements.txt for the index-url, so it has to be there for us to have it later. A proper fix will be more complicated...having the token (which expires after 24 hours) not be in the requirements.txt isn't particularly urgent or high-priority, so I'll leave this as a future task.

@oliviagyg oliviagyg closed this Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant