Skip to content

SYCL: Add non-contiguous support in ROPE #12993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

SYCL: Add non-contiguous support in ROPE #12993

merged 1 commit into from
Apr 21, 2025

Conversation

qnixsynapse
Copy link
Collaborator

Fixed and enabled non-contiguous input support in neox and norm ROPE. Also did a slight formatting.

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Apr 17, 2025
@Rbiessy
Copy link
Collaborator

Rbiessy commented Apr 18, 2025

Did you verify this is tested in test-backend-ops?

@qnixsynapse
Copy link
Collaborator Author

@Rbiessy
Copy link
Collaborator

Rbiessy commented Apr 18, 2025

Right but I mean do the tests have a configuration with non-contiguous rope?

@qnixsynapse
Copy link
Collaborator Author

qnixsynapse commented Apr 18, 2025

Right but I mean do the tests have a configuration with non-contiguous rope?

Yes.

Please see:

struct test_rope : public test_case {
const ggml_type type;
const std::array<int64_t, 4> ne_a;
int n_dims;
int mode;
int n_ctx; // used to generate positions
float fs; // freq_scale
float ef; // ext_factor
float af; // attn_factor
bool ff;
int v; // view (1 : non-contiguous a)
bool forward;

@qnixsynapse qnixsynapse merged commit 5368ddd into master Apr 21, 2025
58 of 61 checks passed
@qnixsynapse qnixsynapse deleted the rope_nc branch April 21, 2025 13:44
colout pushed a commit to colout/llama.cpp that referenced this pull request Apr 21, 2025
pockers21 pushed a commit to pockers21/llama.cpp that referenced this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants