-
Notifications
You must be signed in to change notification settings - Fork 12k
SYCL: add gelu_erf kernel #13749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYCL: add gelu_erf kernel #13749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, seems like sycl is missing GGML_ROPE_TYPE_MROPE
, do you want to give it a try? This type is used by text model, so it will speed up text generation for qwen 2.5
Ref PR where I added it on metal: #13457
Sure. I implemented vision ROPE recently. Will open a new PR for that. |
a2ef2d3
to
bffd38f
Compare
Co-authored-by: Atharva Dubey <[email protected]>
9a94f9f
to
9897da7
Compare
Make sure to read the contributing guidelines before submitting a PR