-
Notifications
You must be signed in to change notification settings - Fork 12.1k
Metal support for Swift #3078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jhen0409
merged 6 commits into
ggml-org:master
from
kchro3:kchro3/llama-swift-metal-support
Sep 9, 2023
Merged
Metal support for Swift #3078
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
89a96fd
Metal support for Swift
kchro3 ce92d75
update
kchro3 99f85e7
add a toggle for arm/arm64
kchro3 690c794
set minimum versions for all platforms
kchro3 24013b3
update to use newLibraryWithURL
kchro3 d58af4d
bump version
kchro3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,12 +141,20 @@ @implementation GGMLMetalClass | |
|
||
ctx->d_queue = dispatch_queue_create("llama.cpp", DISPATCH_QUEUE_CONCURRENT); | ||
|
||
#if 0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thought it would be ok to replace this since it looked unfinished. |
||
// compile from source string and show compile log | ||
#ifdef GGML_SWIFT | ||
// load the default.metallib file | ||
{ | ||
NSError * error = nil; | ||
|
||
ctx->library = [ctx->device newLibraryWithSource:msl_library_source options:nil error:&error]; | ||
NSBundle * bundle = [NSBundle bundleForClass:[GGMLMetalClass class]]; | ||
NSString * llamaBundlePath = [bundle pathForResource:@"llama_llama" ofType:@"bundle"]; | ||
NSBundle * llamaBundle = [NSBundle bundleWithPath:llamaBundlePath]; | ||
NSString * libPath = [llamaBundle pathForResource:@"default" ofType:@"metallib"]; | ||
NSURL * libURL = [NSURL fileURLWithPath:libPath]; | ||
|
||
// Load the metallib file into a Metal library | ||
ctx->library = [ctx->device newLibraryWithURL:libURL error:&error]; | ||
|
||
if (error) { | ||
metal_printf("%s: error: %s\n", __func__, [[error description] UTF8String]); | ||
return NULL; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.