Added OpenVino init on state #2464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Oct 7, 2024
|
I'll test this soon and will update here if everything will work as expected. Didn't expect that you'll review so fast :) |
ggerganov
reviewed
Oct 7, 2024
Just tested this change and now it's working as expected: |
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Oct 21, 2024
* ggerganov/master: readme : update links and make commands (ggml-org#2489) ruby : fix bindings (ggml-org#2484) readme : add Vulkan notice (ggml-org#2488) make : fix GGML_VULKAN=1 build (ggml-org#2485) whisper : add dtw preset for large-v3-turbo (ggml-org#2481) convert : handle max_target_positions (ggml-org#2477) readme : update the Quick Start section (ggml-org#2475) whisper : add OpenVINO init with state (ggml-org#2464)
lyapple2008
pushed a commit
to lyapple2008/whisper.cpp.mars
that referenced
this pull request
Nov 2, 2024
* Fixed OpenVino init on state * Removed an empty line * Fixed typo * Replaced tabs with spaces --------- Co-authored-by: Sandro Hanea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @ggerganov,
I am trying to add support for OpenVino for whisper.net and observed that the init function
whisper_ctx_init_openvino_encodercan only be called on the default context-owned state which I'm not using as I manage multiple parallel states.This PR is adding a new API function
whisper_ctx_init_openvino_encoder_with_statethat basically is doing the same thing on the provided state.