cmake : fix compile assumptions for power9/etc #2777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase on latest |
fitzsim
reviewed
Feb 4, 2025
README.md
Outdated
| @@ -14,7 +14,7 @@ High-performance inference of [OpenAI's Whisper](https://github.com/openai/whisp | |||
| - Plain C/C++ implementation without dependencies | |||
| - Apple Silicon first-class citizen - optimized via ARM NEON, Accelerate framework, Metal and [Core ML](#core-ml-support) | |||
| - AVX intrinsics support for x86 architectures | |||
| - VSX intrinsics support for POWER architectures | |||
| - VSX intrinsics support for POWER architectures(#power-vsx-intrinsics) | |||
There was a problem hiding this comment.
Does this link work without [...] to indicate the link text?
There was a problem hiding this comment.
It does not; corrected.
|
Without this patch on my system |
* Add small comment re: VSX to readme
midnightmagic
force-pushed
the
fix-power9-cmake-logic
branch
from
931ffce to
9581255
Compare
|
As requested—force-pushed a rebase on current master as of a few minutes ago. |
ggerganov
approved these changes
Feb 5, 2025
joelvaneenwyk
pushed a commit
to joelvaneenwyk/whisper-cpp
that referenced
this pull request
Mar 3, 2025
* Add small comment re: VSX to readme Co-authored-by: midnight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in the move to CMake and with the
patch for POWER10 support.
This patch corrects CMake build logic to correctly detect and define
-cpu=power9 during build, which turns back on all the VSX codepaths
for POWER9 machines.
Results especially with -DGGML_BLAS=1 restore whisper.cpp performance
to faster-than-realtime transcription with the medium-q5 model on a
Talos II underclocked to 3.3GHz.