-
Notifications
You must be signed in to change notification settings - Fork 14
Improvements to compile and run Kube 1.6 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahakanbaba
wants to merge
19
commits into
ghodss:master
Choose a base branch
from
ahakanbaba:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The systemd was not getting the changed docker command line parameters. One needed to texecute a systemctl daemon-reload function Some minor refactoring too
Gopath setup and all go get code is factored out into functions. It looks like one does not need the sudoer change anymore. Also added net-tools installation for ifconfig command
does not cause any problem.s Factored out the profile file generation code to a function. Passing Dropped the trailing slash from GOPATH
nfs3 and udp. So no need to set them again
Also configuring the guest ip correctly. With this change I can build the local-up-cluster in the vm and connect to it from the osx host machine.
Typo fixes, Function name changes, Adding a guard if the HOST_GOPATH is not given.
This compiles 1.6 and runs local-up-cluster sucessfully.
For some reason this pull request shows much more commits than there is . :( |
Also remove the ALLOW_ANY_TOKEN env var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.