Skip to content

Unlink the Java GCM from Homebrew if installed #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2019
Merged

Unlink the Java GCM from Homebrew if installed #45

merged 1 commit into from
May 23, 2019

Conversation

mjcheetham
Copy link
Collaborator

If the Java GCM is installed via Homebrew, attempt to unlink it before creating the GCM Core symlink in /usr/local/bin.

Also include the -F option when creating the symlink for good measure to force overwriting whatever file might already be there. Technically we only need to do this step and not the brew unlink but we should try and let Homebrew remove the links it placed rather than just walking over them.

Fixes #44

@mjcheetham mjcheetham added bug A bug in Git Credential Manager platform:osx Specific to the macOS platform labels May 22, 2019
Copy link

@kewillford kewillford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@jamill jamill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks. Just a couple of thoughts for your consideration.

Are there any details that we would want to include in the README?

I see we unlink java GCM - I suspect that most users would could just remove Java GCM. It is probably not the place of your installer to do this, but maybe a note in the Readme / installation instructions could indicate that this replaces the Java GCM and how they could remove it if they wanted to?

@mjcheetham
Copy link
Collaborator Author

Looks good! Thanks. Just a couple of thoughts for your consideration.

Are there any details that we would want to include in the README?

I see we unlink java GCM - I suspect that most users would could just remove Java GCM. It is probably not the place of your installer to do this, but maybe a note in the Readme / installation instructions could indicate that this replaces the Java GCM and how they could remove it if they wanted to?

Updated the "Download and Install" instructions on the README.md to include a note that the Java GCM will be unlinked if currently installed.

@mjcheetham mjcheetham merged commit b358326 into git-ecosystem:master May 23, 2019
@mjcheetham mjcheetham deleted the unlink-javagcm branch May 23, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in Git Credential Manager platform:osx Specific to the macOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails to create symlink when Java GCM is installed
3 participants