New Install 2/6: Rename main executable to GCM Core to make SxS easier #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
changed the title
jrbriggs
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
Approved assuming we don't also need to update
src\osx\Installer.Mac\scripts\configure-git.sh:11:git config --system credential.helper /usr/local/share/gcm-core/git-credential-manager
which I assume will be addressed by the rest of this series. If not, we should fix that here.
Ah! Good catch. Yes, this is addresses in #73 but I'll update it in this PR too so that each merge commit is 'good' 😄 |
mjcheetham
force-pushed
the
rename-exec
branch
from
918b9ed to
fede2cf
Compare
Rename the main executable to include "-core" to make side-by-side installs of GCM Core and Windows-only GCM easier. We can just change the configuration between "manager" and "manager-core".
mjcheetham
force-pushed
the
rename-exec
branch
from
fede2cf to
d5d25f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the main executable to include "-core" to make side-by-side installs of GCM Core and Windows-only GCM easier.
We can just change the configuration between "manager" and "manager-core".
Note for reviewers: please wait until #69 is complete for an easier time reviewing, or just view the latest commit in this PR as this branch is based on changes from #69.