Add ISystemPrompts component and impl for Windows #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
force-pushed
the
basic-nativeui
branch
2 times, most recently
from
14d5e69 to
0b9bde1
Compare
mjcheetham
added
enhancement
jrbriggs
approved these changes
Feb 7, 2020
src/shared/Microsoft.Git.CredentialManager/Interop/Windows/WindowsSystemPrompts.cs
Outdated
Show resolved
Hide resolved
Introduce the `ISystemPrompts` component which provides native/system UI prompts, starting with basic credential prompts. Include a basic implementation for Windows.
Wire up the parent window handle to system prompts and UI helpers.
mjcheetham
force-pushed
the
basic-nativeui
branch
from
64f206f to
22da69c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
ISystemPromptscomponent which provides native/system UI prompts, starting with basic credential prompts. Include a basic implementation for Windows.We can introduce a Mac implementation later either using a built-in credential prompt, or bundling a our own simple Cocoa app.
This feature will allow basic authentication when the TTY is not available (such as when run from within a GUI app like Visual Studio).
Partly addresses #93.