Correctly check for GUI on Win/Mac/POSIX #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
force-pushed
the
fix-desktopcheck
branch
3 times, most recently
from
94c7596 to
4e570e9
Compare
mjcheetham
force-pushed
the
fix-desktopcheck
branch
from
4e570e9 to
df4bf89
Compare
mjcheetham
force-pushed
the
fix-desktopcheck
branch
from
df4bf89 to
4da4ce2
Compare
dscho
reviewed
May 18, 2020
dscho
approved these changes
May 18, 2020
Replace the `PlatformUtils.IsDesktopSession` util method with platform specific components that check use native APIs to determine the state of the current session. `Environment.UserInteractive` is hard-coded to return true for POSIX and Windows platforms on .NET Core 2.x and 3.x. dotnet/runtime#770 The .NET 5 implementation (not yet released) fixes this for the Windows platform only. We take a copy of that implementation for Windows. On macOS we use the `SessionGetInfo` from the Security.framework. On POSIX in general we also check for the X11 $DISPLAY environment variable.
mjcheetham
force-pushed
the
fix-desktopcheck
branch
from
4da4ce2 to
0437eb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
PlatformUtils.IsDesktopSessionutil method with platform specific components that check use native APIs to determine the state of the current session.Environment.UserInteractiveis hard-coded to return true for POSIX and Windows platforms on .NET Core 2.x and 3.x.dotnet/runtime#770
The .NET 5 implementation (not yet released) fixes this for the Windows platform only. We take a copy of that implementation for Windows.
On macOS we use the
SessionGetInfofrom the Security.framework.On POSIX in general we also check for the X11 $DISPLAY environment variable.