Skip to content

Use the pre-built vcpkg packages in the vs-build(arm64) job #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dscho
Copy link
Member

@dscho dscho commented Dec 15, 2020

This should shave off about 16 minutes off of our PR builds.

Let's use the pre-built vcpkg artifacts instead of building the packages
ourselves in _every_ single CI run. This saves quite a bit of time:
about 1 minute to download & unpack the artifacts vs about 17 minutes to
build them (and forcing `vs-test` and `windows-test` to wait for it).

Signed-off-by: Johannes Schindelin <[email protected]>
@rimrul
Copy link
Member

rimrul commented Dec 16, 2020

We should probably extend vs-test to also cover arm64. Can't have that much time saved.

@rimrul
Copy link
Member

rimrul commented Dec 16, 2020

Scratch that. GitHub actions do not currently support ARM64 Windows.
See also actions/runner-images#768 and actions/runner#785

@dscho
Copy link
Member Author

dscho commented Dec 16, 2020

@rimrul good find. And yes, I am aware that neither Azure Pipelines nor GitHub Actions offer Windows/ARM64 agents at the moment.

@rimrul may I take your taking time to comment as approval for this PR?

@rimrul
Copy link
Member

rimrul commented Dec 17, 2020

Yes.

  • less unnescessary waiting
  • fewer unnescessary differences between the VS builds for AMD64 and ARM64
  • the CI builds still pass
  • no obvious downsides

That's an improvement in my books.

@dscho dscho merged commit 2d86808 into git-for-windows:main Dec 17, 2020
@dscho dscho deleted the use-precompiled-arm64-vcpkg-artifacts branch December 17, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants