Adjust the Windows download links #2001
Conversation
As of v2.49.0, Git for Windows no longer ships 32-bit (also known as "i686" or "Intel 32-bit") installers. However, Git for Windows started shipping ARM64 versions since v2.47.1. Let's accommodate for that by recording these artifacts, using the CPU architecture rather than merely the bitness (which would now be meaningless because both x64 and arm64 are 64-bit). Subsequent commits will consume these new data items. Signed-off-by: Johannes Schindelin <[email protected]>
Now that the `update-download-data.rb` script records x64/ARM64 data, let's update `hugo.yml` after running this script. Signed-off-by: Johannes Schindelin <[email protected]>
assets/js/application.js
Outdated
| const version = $('#auto-download-version'); | ||
| const architecture = $('#auto-download-architecture'); | ||
| const date = $('#auto-download-date'); | ||
| if (link.length && version.length && bitness.length && date.length) { |
There was a problem hiding this comment.
| if (link.length && version.length && bitness.length && date.length) { | |
| if (link.length && version.length && browser.bitness.length && date.length) { |
There was a problem hiding this comment.
Oh, you're right, this must be the problem. But it should be changed to architecture instead of browser.bitness. Hold on a sec.
There was a problem hiding this comment.
In about 5 minutes, https://github.com/dscho/git-scm.com/actions/runs/14752148979 should be done and it should be fixed at https://dscho.github.io/git-scm.com/downloads/win
There was a problem hiding this comment.
Can confirm that it now correctly shows all ARM64 links. Thanks! 🎉
There was a problem hiding this comment.
@dennisameling could you have another look, please?
There was a problem hiding this comment.
Not sure if you saw my comment from ~8 mins ago, but the ARM64 links are still showing up correctly as per your latest commit 👍🏼
There was a problem hiding this comment.
Oops. I had expected GitHub to update my browser page automatically, had not seen your answer! Thank you for confirming (twice!)!
As of v2.47.1, Git for Windows provides an ARM64 version, and as of v2.49.0 it stopped providing an i686 version. The preceding commit updated the information in `hugo.yml` to reflect this, and now it is time to use that information to present the download links accordingly. Signed-off-by: Johannes Schindelin <[email protected]>
The information is now stored by CPU architecture, no longer by bitness. Let's drop the parts that are no longer needed (and wouldn't be updated, anyway). Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
adjust-windows-download-links-again
branch
from
7a1b496 to
d859fc7
Compare
Changes
Context
Git for Windows v2.47.1 was the first version to provide an ARM64 version, and v2.49.0 stopped providing an i686 version. This needs to be reflected in the download link handling.
I got inspired to make this change by git-for-windows/git-for-windows.github.io#61 of which this here PR is a natural companion.
@dennisameling would you mind testing (but not in Firefox, where this is known not to work) whether https://dscho.github.io/git-scm.com/downloads/win shows the ARM64 download link for you, i.e. not the following?