Branch button no longer opens branch in browser

[fgLouro]

Version

0.12.16

Operating System

Mac OS X

Distribution Method

dmg (Apple Silicon)

Describe the issue

Usually the button origin/<branch-name> would open a new tab on my browser to my branch inside of my repository. Now it seems to no longer work.

Clicking on the button doesn't do anything. Maybe coming from the last update or the one before that. Only notice it this week.

How to reproduce

Apply branch that has an remote branch and try to click the button.

Expected behavior

Clicking on the button should open a web page to the repository in the correct branch

Relevant log output

No response

[Caleb-T-Owens]

Hey! Thanks for reporting! I'm working on a fix for that now 👍

[fgLouro]

Hey @Caleb-T-Owens, sorry to bother you, but was this PR #4634 that was released with v0.12.19 related to this issue?

[Caleb-T-Owens]

Hi @fgLouro, yes! It should be resolved now. Feel free to reopen if you find any edge cases

[fgLouro]

It still not working for me. I didn't mention in the issue but i'm using Gitlab, which should be an issue because it worked before.

Is there anything I can provide you to better debug this?

[Caleb-T-Owens]

@fgLouro I've just tried it out and noticed that I need to have the github integration set up to see the link, but once that is done, it works as expected.

I'm going to re-open the issue as that is not intended, but if you could confirm that that is also the case for you, that would be appreciated

[fgLouro]

I can confirm that it does work when the Github integration is connect to a Github repository.

[ndom91]

@fgLouro it should work with Gitlab URLs with the latest releases as well 👍

[fgLouro]

Sorry but it is not working.

I setup the project to run locally to debug the issue and the gitHostBranch is always undefined.

This is in the BranchPreviewHeader.svelte

Also when I apply the branch it is the same issue

This is in the ActiveBranchStatus.svelte

If I replace const url = gitHostBranch?.url; with a hard coded url it works.

Screen.Recording.2024-08-16.at.13.01.56.mov

Can this be an issue with my git configuration if so what should I look at?

[fgLouro]

After further digging I found that the DefaultGitHostFactory build function is not having into account the gitlab instances that are self hosted.

Here is the repo sent to the build function:

The problem is that gitbutler is assuming that the gitlab domains always ends with gitlab.com, when self host instances of gitlab have the format gitlab.{domain}

My guess is that the issue was introduced in this commit: e1f9c8b