Skip to content

Add helper function for matching trees, and start testing rebasing. #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Caleb-T-Owens
Copy link
Contributor

Basic rebasing tests

@github-actions github-actions bot added the rust Pull requests that update Rust code label Sep 26, 2024
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 1:21pm

Copy link
Member

@krlvi krlvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best code I've ever seen!

@Caleb-T-Owens Caleb-T-Owens merged commit 01584fc into master Sep 26, 2024
18 checks passed
@Caleb-T-Owens Caleb-T-Owens deleted the rebase-tests branch September 26, 2024 13:25
@@ -419,11 +421,237 @@ fn resolve_index(

#[cfg(test)]
mod test {
use std::path::Path;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly recommend to put tests for the public API into integration-./tests next to ./src. That way, the source file won't be cluttered up and one is assured to test like one would as consumer of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants