Skip to content

fix: update GitLab merge request prefix to '!' #8227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

nolith
Copy link
Contributor

@nolith nolith commented Apr 22, 2025

Change the prefix for GitLab merge requests from '#' to '!' in the PullRequestCard component to correctly reflect markdown syntax.

🧢 Changes

In #8221 the ability to distinguish UI elements by forge was introduced, but the correct MR symbol for GitLab is !.

☕️ Reasoning

If this PR is related to a specific issue, uncomment this section
and link it via the following text:

🎫 Affected issues

Fixes: #8210

Change the prefix for GitLab merge requests from '#' to '!' in the  
PullRequestCard component to correctly reflect markdown syntax.
Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 0:41am

Copy link

vercel bot commented Apr 22, 2025

@nolith is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@nolith
Copy link
Contributor Author

nolith commented Apr 22, 2025

@estib-vega this should close #8210 on top of your work, do you mind taking a look? 🙏

@estib-vega
Copy link
Contributor

@nolith oh dumb mistake of mine. Nice catch!

@estib-vega estib-vega enabled auto-merge April 22, 2025 12:45
@estib-vega estib-vega merged commit 3ee6f5a into gitbutlerapp:master Apr 22, 2025
18 of 19 checks passed
@nolith nolith deleted the ac-fix-gl-mr-symbol branch April 22, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitLab: broken links in stacked merge requests
2 participants