Skip to content

Update RoundImplementation.json and Data Layer Test #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025

Conversation

kilavvy
Copy link
Contributor

@kilavvy kilavvy commented Feb 26, 2025

  1. RoundImplementation.json:

    • Added a new field for the recipient with the internal type set to "address payable".
    • Updated the state mutability type for the "receive" function.
  2. data-layer.test.ts:

    • Added a comment indicating that the mock projects are sourced from an actual project on the Sepolia network.

These updates enhance the clarity and functionality of the contract implementation and improve the test setup for the data layer.

@kilavvy kilavvy requested review from a team as code owners February 26, 2025 15:53
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 5:19pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 5:19pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 5:19pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 5:19pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 5:19pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 5:19pm

@kilavvy
Copy link
Contributor Author

kilavvy commented Apr 1, 2025

@hussedev

@MasterHW MasterHW merged commit a3f1ba7 into gitcoinco:main Apr 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants