Skip to content

Use consistant wording for the word GitHub.com #21565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

indigolain
Copy link
Contributor

Why:

The pages other than this uses the word GitHub.com instead of Github.com.
It seems more natural to use the same wording.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Changed the wording from Github.com to GitHub.com.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Oct 23, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
code-security/dependabot/dependabot-alerts/editing-security-advisories-in-the-github-advisory-database.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae
fpt
ghec
ghes@ 3.7 3.6 3.5 3.4 3.3
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@indigolain indigolain closed this Oct 23, 2022
@indigolain indigolain deleted the use-consistant-wording-for-github-dot-com branch October 23, 2022 06:47
@cmwilson21
Copy link
Contributor

@indigolain - Noticed this PR was closed. Do you no longer wish to submit it?

Thanks for spotting it!

@indigolain indigolain restored the use-consistant-wording-for-github-dot-com branch October 24, 2022 23:44
@indigolain indigolain reopened this Oct 24, 2022
@indigolain
Copy link
Contributor Author

indigolain commented Oct 24, 2022

@cmwilson21
I noticed that the wording in the image shown in the page was actually Github.com, so I decided to closed it, but I would love to submit if the change seems reasonable on your end!

Screen Shot 2022-10-25 at 8 53 00

@cmwilson21
Copy link
Contributor

@indigolain Thanks for reopening this! Per our brand guidelines, the G and the H are always capitalized. I see what you are saying in the screenshot, though. Are you able to confirm that screenshot? That the link from an Enterprise Server instance still shows Github.com as opposed to GitHub.com?

I'm going to dig around a little more on this, too. Thanks again for spotting this! 👀

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team labels Oct 25, 2022
@indigolain
Copy link
Contributor Author

indigolain commented Oct 25, 2022

@cmwilson21
I've confirmed from the links in the generated comment, that the screenshot in [email protected]'s Edit Advisory Database(production) had Github.com in the image shown in the page!

Hope this info could help you spot it 🙏

@mchammer01 mchammer01 self-requested a review October 25, 2022 07:33
@mchammer01
Copy link
Contributor

mchammer01 commented Oct 25, 2022

@indigolain - thanks for spotting this capitalization inconsistency ✨
I have brought this up with the database advisory team so that hopefully we'll get this fixed in the UI.
I will merge your PR in the meantime (and we'll update the screenshot once the fix is in production).

@mchammer01 mchammer01 enabled auto-merge October 25, 2022 07:45
mchammer01
mchammer01 previously approved these changes Oct 25, 2022
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot, thank you 💖

@mchammer01 mchammer01 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 25, 2022
…urity-advisories-in-the-github-advisory-database.md
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link

@chrisbloom7 chrisbloom7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍🏻 from advisory database

@cmwilson21 cmwilson21 added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 26, 2022
@cmwilson21
Copy link
Contributor

@indigolain Thanks for this great contribution! If you are participating in hacktoberfest and looking for more ways to contribute, check out our help wanted section to find open issues you can work on.

We have a few issues that could use some extra help. If you’re up for working on another, more involved help wanted issue, look for the pumpkin-spice label.

Thanks again!

@mchammer01 mchammer01 merged commit 06fea98 into github:main Oct 26, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@indigolain indigolain deleted the use-consistant-wording-for-github-dot-com branch October 26, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants