-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Update merge-queue gated feature for GHES 3.12 #31946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "who can use this feature" section for Merge Queue related docs (when viewing GHES 3.12) is confusing since it currently only mentions Enterprise Cloud. This updates that to indicate MQ is available on all org-owned repos in GHES. Note: the MQ feature is currently gated to GHES 3.12 and later.
isaacmbrown
reviewed
Mar 5, 2024
isaacmbrown
reviewed
Mar 5, 2024
isaacmbrown
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @willsmythe 🙇
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The "Who can use this feature" section for Merge Queue related docs (when viewing GHES 3.12) is confusing since it currently only mentions Enterprise Cloud. For example:
https://docs.github.com/en/[email protected]/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue
This change updates the gated feature details to be correct for GHES.
Note: the MQ feature is currently gated to GHES 3.12 and later.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Fixes the "Who can use this feature" section on Merge Queue related pages when viewing GHES 3.12 and later docs.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.