Skip to content

[fix] fixes css issue in the browser extension #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2022

Conversation

AllMight2099
Copy link
Contributor

@AllMight2099 AllMight2099 commented May 5, 2022

Description

Fixes the CSS issue where the Gitpod button was broken on the page where you create a new repository and when you visit a specific file on GitHub

Case 1: When you create a new repository Case 2: When you visit a specific file
Screenshot from 2022-05-05 22-34-39 Screenshot from 2022-05-05 22-35-52

Related Issue(s)

Fixes gitpod-io/gitpod#9435

@andreafalzetti
Copy link
Contributor

andreafalzetti commented May 6, 2022

Thanks a lot @AllMight2099 for this contribution 🙏

A few days ago, I actually spotted the same and tried to fix it. My first attempt wasn't successful, and I had a reminder to raise an issue.. so it's awesome to see you found a nice solution :)

I've tested and it works as expected now, the button for new repositories is shown properly 🧡🙏

Before After
Screenshot 2022-05-06 at 09 01 42 Screenshot 2022-05-06 at 09 01 53
Screenshot 2022-05-06 at 09 06 58 Screenshot 2022-05-06 at 09 02 31
Screenshot 2022-05-06 at 09 09 50 Screenshot 2022-05-06 at 09 10 28

@andreafalzetti andreafalzetti self-requested a review May 6, 2022 07:09
@gtsiolis
Copy link
Contributor

gtsiolis commented May 6, 2022

Whoa, thanks for fixing this, @AllMight2099! It has been bothering me for weeks. 🍊

Thanks also, @andreafalzetti, for reviewing this! 🏀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Gitpod button position in browser extension
3 participants