Fix typos #2649
Open
Fix typos #2649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cruessler
requested changes
May 25, 2025
| @@ -82,7 +82,7 @@ impl ExternalEditorPopup { | |||
|
|
|||
| // deal with "editor name with spaces" p1 p2 p3 | |||
| // and with "editor_no_spaces" p1 p2 p3 | |||
| // does not address spaces in pn | |||
| // does not address spaces in on | |||
There was a problem hiding this comment.
Should this still be pn as it is a generalization of p1 p2 p3?
There was a problem hiding this comment.
@kianmeng please revert that
ada4a
reviewed
May 27, 2025
| @@ -611,10 +611,10 @@ mod tests { | |||
|
|
|||
| tree.collapse(1, false); | |||
|
|
|||
| let visibles = get_visible(&tree); | |||
There was a problem hiding this comment.
I think this one was actually right, or at least intentional -- get_visible returns for each tree item whether it's visible or not, so a list of visibles, so a visibles. If anything, I would rename both the variable and the helper function to visibilities and get_visibilities, respectively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #{issue_num}.
It changes the following:
typos --hidden --format briefI followed the checklist:
make checkwithout errors