Skip to content

React 19 Support #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,12 @@ jobs:
node-version: 20.10.0
- run: npm install
- run: npm run test-18
test-react-19:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20.10.0
- run: npm install
- run: npm run test-19
24 changes: 0 additions & 24 deletions .storybook/.babelrc.json

This file was deleted.

15 changes: 0 additions & 15 deletions .storybook/addons/expand-all/register.mjs

This file was deleted.

33 changes: 0 additions & 33 deletions .storybook/main.js

This file was deleted.

31 changes: 0 additions & 31 deletions .storybook/main.ts

This file was deleted.

32 changes: 0 additions & 32 deletions .storybook/manager.ts

This file was deleted.

1 change: 0 additions & 1 deletion .storybook/preview-body.html

This file was deleted.

23 changes: 0 additions & 23 deletions .storybook/preview-head.html

This file was deleted.

14 changes: 0 additions & 14 deletions .storybook/preview.ts

This file was deleted.

5 changes: 2 additions & 3 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@
"type": "npm",
"script": "start",
"isBackground": true,

"problemMatcher": {
"pattern": {
"regexp": ".*"
},
"background": {
"activeOnStart": true,
"beginsPattern": "^.*Starting Storybook.*$", // Adjust if there's a more specific start message
"endsPattern": "^.*Storybook \\d+.\\d+.\\d+ for react-webpack5 started.*$"
"beginsPattern": "^.*Server running.*$",
"endsPattern": "^.*Available on:.*$"
}
},
"group": {
Expand Down
4 changes: 3 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ is to use Codespaces if you have access to it. If you do not, simply cloning the
Once codespaces is up and running make sure `jq` is installed and then:

```bash
npm run install && npm run storybook
npm install && npm run start
```

This will build the packages and serve the core package for testing.

## Forking the data grid?

Please consider submitting your work for review. We are a small project, but we are super enthused when anyone comes by to help us build the best damned data grid on the internet.
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@
</picture>

[![Version](https://img.shields.io/npm/v/@glideapps/glide-data-grid?color=blue&label=latest&style=for-the-badge)](https://github.com/glideapps/glide-data-grid/releases)
[![React 16+](https://img.shields.io/badge/React-16+-00ADD8?style=for-the-badge&logo=react)](https://reactjs.org)
[![React 16-19](https://img.shields.io/badge/React-16--19-00ADD8?style=for-the-badge&logo=react)](https://reactjs.org)
[![Code Coverage](https://img.shields.io/coverallsCoverage/github/glideapps/glide-data-grid?color=457aba&label=Cover&style=for-the-badge)](https://coveralls.io/github/glideapps/glide-data-grid)
[![npm bundle size](https://img.shields.io/bundlephobia/minzip/@glideapps/glide-data-grid?color=success&label=bundle&style=for-the-badge)](https://bundlephobia.com/package/@glideapps/glide-data-grid)
[![License](https://img.shields.io/github/license/glideapps/glide-data-grid?color=red&style=for-the-badge)](https://github.com/glideapps/glide-data-grid/blob/main/LICENSE)
[![Made By Glide](https://img.shields.io/badge/❤_Made_by-Glide-11CCE5?style=for-the-badge&logo=none)](https://www.glideapps.com/jobs)

# 👩‍💻 Demo and features

Lots of fun examples are in our [Storybook](https://glideapps.github.io/glide-data-grid).
Lots of fun examples can be found in the test-projects directory.

You can also visit our [main site](https://grid.glideapps.com).

Expand All @@ -40,7 +40,7 @@ You can also visit our [main site](https://grid.glideapps.com).

# ⚡ Quick Start

First make sure you are using React 16 or greater. Then install the data grid:
First make sure you are using React 16 or greater (including React 17, 18, and 19). Then install the data grid:

```shell
npm i @glideapps/glide-data-grid
Expand Down Expand Up @@ -130,7 +130,7 @@ Data Grid is agnostic about the way you load/store/generate/mutate your data. Wh

**Does it do sorting, searching, and filtering?**

Search is included. You provide the trigger, we do the search. [Example](https://glideapps.github.io/glide-data-grid/?path=/story/glide-data-grid-docs--search) in our storybook.
Search is included. You provide the trigger, we do the search.

Filtering and sorting are something you would have to implement with your data source. There are hooks for adding column header menus if you want that.

Expand All @@ -142,7 +142,7 @@ Yes!

**Can I render my own cells?**

Yes, but the renderer has to use HTML Canvas. [Simple example](https://glideapps.github.io/glide-data-grid/?path=/story/glide-data-grid-dataeditor-demos--draw-custom-cells) in our Storybook.
Yes, but the renderer has to use HTML Canvas.

**Why does Data Grid use HTML Canvas?**

Expand Down
Loading