-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Show required commit status which haven’t been done yet #21892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this has been implemented, you can find it in the branch protection page. |
I can't find a setting in the branch protection, might be a 1.18 feature (currently running 1.17.3) |
This still seems to be missing, unless I'm missing an option. If you have a required check called "A" and open a PR for the protected branch, but the commit doesn't have any status from the check "A", then the PR page just says that there are missing checks, but not which checks are missing. |
It not only does not show required checks in PR view, it also allows merging PR while CI has not reported any status for required checks that are set in branch protection rules |
This one already bit us 4-5 times since 1.20 and the introduction of patterns for status checks :) |
Is there a way to set required checks as pending on the side of Gitea? |
I gave it a shot to fix the problem with the linked PR |
fixes #21892 This PR disallows merging a PR when not all commit status contexts configured in the branch protection are met. Previously, the PR was happy to merge when one commit status was successful and the other contexts weren't reported. Any feedback is welcome, first time Go :-) I'm also not sure if the changes in the template break something else Given the following branch protection:  This was shown before the change:  With the change, it is now shown as this:  --------- Co-authored-by: wxiaoguang <[email protected]>
fixes go-gitea#21892 This PR disallows merging a PR when not all commit status contexts configured in the branch protection are met. Previously, the PR was happy to merge when one commit status was successful and the other contexts weren't reported. Any feedback is welcome, first time Go :-) I'm also not sure if the changes in the template break something else Given the following branch protection:  This was shown before the change:  With the change, it is now shown as this:  --------- Co-authored-by: wxiaoguang <[email protected]>
fixes go-gitea#21892 This PR disallows merging a PR when not all commit status contexts configured in the branch protection are met. Previously, the PR was happy to merge when one commit status was successful and the other contexts weren't reported. Any feedback is welcome, first time Go :-) I'm also not sure if the changes in the template break something else Given the following branch protection:  This was shown before the change:  With the change, it is now shown as this:  --------- Co-authored-by: wxiaoguang <[email protected]>
fixes go-gitea#21892 This PR disallows merging a PR when not all commit status contexts configured in the branch protection are met. Previously, the PR was happy to merge when one commit status was successful and the other contexts weren't reported. Any feedback is welcome, first time Go :-) I'm also not sure if the changes in the template break something else Given the following branch protection:  This was shown before the change:  With the change, it is now shown as this:  --------- Co-authored-by: wxiaoguang <[email protected]> (cherry picked from commit a11ccc9)
Automatically locked because of our CONTRIBUTING guidelines |
Feature Description
If a base branch has a protection requiring a check, but the check hasn’t been started for a commit yet, then there is no indication in the pull which checks are missing.
aside from pending, failed, succeeded etc checks, the pull page could also render missing checks (required checks that haven’t reported any status for the commit yet)
Screenshots
No response
The text was updated successfully, but these errors were encountered: